config_accessor should better not be a public method, as with Ruby's attr_accessor #18610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's fine, but we may need a changelog entry. |
|
LGTM, not sure if Changelog is needed TBH |
|
I'd include a CHANGELOG entry just to be safe |
amatsuda
force-pushed
the
privatize_config_accessor
branch
from
c8ca8ec
to
c2bfe6c
Compare
amatsuda
added a commit
that referenced
this pull request
Feb 5, 2015
config_accessor should better not be a public method, as with Ruby's attr_accessor
|
❤️ 💚 💙 💛 💜 |
|
It seems like ever since this commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it's not intentional that
config_accessoris publicly callable.Who actually calls the accessor from outside?