Test activerecord/lib/test/relations_test.rb:reverse_sql_order fails because 'reverse' is not defined as an instance method of Arel::Nodes::Ordering #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
activrecord/../query_methods.rb Test activerecord/lib/test/relations_test.rb:reverse_sql_order fails because 'reverse' is not defined as an instance method of Arel::Nodes::Ordering This monkey patches Arel::Nodes::Ordering when 'reverse' is called on an instance. This is clearly the wrong place to do the patch. It should be performed in a callback when Arel is lazily loaded, but it works and allows the test to pass (this point)
|
It is defined. However, a new version of arel needs to be released in order for this to be available. |
|
thanks. I'm closing this |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
…roperly Signed-off-by: Michael Koziarski <michael@koziarski.com> [rails#1865 state:committed]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is monkeypatch to add Arel::Nodes::Ordering#reverse to activerecord/../query_methods.rb
when 'reverse' is called on an instance.
This is clearly the wrong place to do the patch. It should be performed
in a callback when Arel is lazily loaded, but it works and allows
the test to pass (this point)