Fix ActiveJob assertions with a GlobalID object argument

[liseki]

Since 8a73f4b the following no longer works when bob is a GlobalId object:

assert_enqueued_with job: InviteUserJob, args: [bob] do
  some_method_that_triggers_invite_user_job()
end

This patch fixes that and includes tests.

cc @cristianbica

[rafaelfranca]

This is weird. Why original_args is returned and what is mutated is args? Is not better to mutate the args.dup and return it?

[liseki]

Probably a little weird but I need both the original and serialized args. The serialized args are used in the assertion comparison and the original args are used in the failure message if the assertion fails. It probably makes immediate sense if you place that code in the assertion method as follows:

def assert_enqueued_with(args = {}, &_block)
  original_enqueued_jobs = enqueued_jobs.dup
  clear_enqueued_jobs

  args.assert_valid_keys(:job, :args, :at, :queue)
  original_args = args.dup
  if job_args = args.delete(:args)
    args[:args] = ActiveJob::Arguments.serialize(job_args)
  end

  yield
  matching_job = enqueued_jobs.any? do |job|
    args.all? { |key, value| value == job[key] }
  end

  assert matching_job, "No enqueued job found with #{original_args}"
ensure
  queue_adapter.enqueued_jobs = original_enqueued_jobs + enqueued_jobs
end

However I would have to repeat it in assert_performed_with so I decided to place it in a helper method. Would you prefer I remove the helper in favour of the above?

[liseki]

Never mind the above, sorry! It's been a long day :) I'll push an update.

[liseki]

I think that should be OK now. Sorry about that :)

[liseki]

ping @rafaelfranca

[rafaelfranca]

Backported as 6d65df5

[liseki]

Muito obrigado!