Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_finding_with_cross_table_order_and_limit for Oracle #1882

Conversation

rsim
Copy link
Contributor

@rsim rsim commented Jun 28, 2011

Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated.

Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated.
tenderlove added a commit that referenced this pull request Jun 28, 2011
…order_and_limit

Fix test_finding_with_cross_table_order_and_limit for Oracle
@tenderlove tenderlove merged commit 931cf17 into rails:master Jun 28, 2011
@raviolicode
Copy link
Contributor

@rsim, this test's syntax was made on purpose, for the fix on issue #1720, details on the commit are on this pull request.

Looking at the code, maybe this fix can be easily ported by updating here?

@rsim
Copy link
Contributor Author

rsim commented Jun 28, 2011

@raviolicode Sorry, didn't notice that it was on purpose :)
Because of this test my ActiveRecord on Oracle build was broken http://ci.rayapps.com/job/rails-master-activerecord-oracle/129/build_ruby=1.8.7/console

I would prefer to deprecate this old style of passing all order by as one string as in Oracle case I need to split it into array and splitting of this string is quite tricky (as commas can be used to separate function arguments as well). Or if it is still working in MySQL and PostgreSQL and SQLite3 then maybe make this test just for these databases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants