Improve deprecation warning message #18923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -306,7 +306,8 @@ def kwarg_request?(*args) | |||
| def non_kwarg_request_warning | |||
| ActiveSupport::Deprecation.warn(<<-MSG.strip_heredoc) | |||
| ActionDispatch::Integration::TestCase HTTP request methods will accept only | |||
| keyword arguments in future Rails versions. | |||
| the following keyword arguments in future Rails versions: | |||
| #{REQUEST_KWARGS.join(', ')} | |||
There was a problem hiding this comment.
I was doing something like post '/documents', document: { title: "New things", content: "Doing them" } and saw the deprecation message.
It wasn't immediately clear to me what the keyword arguments are.
kaspth
added a commit
that referenced
this pull request
Feb 13, 2015
Improve deprecation warning message
|
Thanks 💛 |
|
@kaspth You're welcome 😄 |
| @@ -314,9 +315,7 @@ def non_kwarg_request_warning | |||
| params: { id: 1 }, | |||
| headers: { 'X-Extra-Header' => '123' }, | |||
| env: { 'action_dispatch.custom' => 'custom' } | |||
There was a problem hiding this comment.
@tgxworld missed adding a trailing coma?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.