Mailer preview now uses url_for to fix links to emails for apps runnin...
#19093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build was affected by the bug @eileencodes mentioned in https://twitter.com/eileencodes/status/572047555875479552 |
|
Wonder whether we should add named routes for this with an |
|
If named routes fixes the urls, that'd be fine too, I'm however not sure if it is needed for this as Rails favors convention over configuration. Also not sure if there's a present need or use case for making it a named route. Thoughts? |
|
Anything else needed for this? It'd be great to see this in Rails as I've had a solution ready for almost a year now to get this fixed. Thanks! |
|
Hi all, I rebased the code so that it can be automatically merged, it looks like it's failing due to an unrelated bug in rails at the moment though. |
…ning on a subdirectory, closes #19092.
rafaelfranca
added a commit
that referenced
this pull request
May 3, 2015
…inks-on-subdirectories Mailer preview now uses `url_for` to fix links to emails for apps runnin...
rafaelfranca
added a commit
that referenced
this pull request
May 4, 2015
…inks-on-subdirectories Mailer preview now uses `url_for` to fix links to emails for apps runnin...
rafaelfranca
added a commit
that referenced
this pull request
May 4, 2015
…inks-on-subdirectories Mailer preview now uses `url_for` to fix links to emails for apps runnin...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...g on a subdirectory, closes #19092.