Preserve Array#take(n) behaviour of HasManyAssociation #19105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelfranca Please take a 👀 |
| def test_taking_with_a_number | ||
| assert_equal [posts(:misc_by_bob)], authors(:bob).posts.take(1) | ||
| assert_equal [posts(:misc_by_bob), posts(:other_by_bob)], authors(:bob).posts.take(2) | ||
| authors(:bob).posts.to_a |
There was a problem hiding this comment.
You want to assert prior to this line that authors(:bob).association(:post) is not loaded. Otherwise you are not testing the "not loaded" code path.
Or for a more black box approach you can do:
assert_queries(1) do
authors(:bob).posts.to_a
endWhich will ensure to_a makes the load happen rather than something earlier.
There was a problem hiding this comment.
Thanks for the comment. Just made it more comprehensible and push -fed.
sgrif
added a commit
that referenced
this pull request
Mar 2, 2015
Preserve Array#take(n) behaviour of HasManyAssociation
sgrif
added a commit
that referenced
this pull request
Mar 2, 2015
Preserve Array#take(n) behaviour of HasManyAssociation
|
I guess this should be backported to 4.1.x and 4.2.x , as this was broken on those branches |
|
I backported this to 4-1-stable, and to 4-1-10 rc, and 4-2-1 rc. (this was on 4-2-stable already) |
mike-stewart
added a commit
to mike-stewart/rails
that referenced
this pull request
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether this behaviour change was by design, so let me PR.
takemethod with an argument had been available on HasManyAssociation until 2b63a35. It used to fallback toArray#take(n).But now
association.take(n)raisesArgumentError: wrong number of arguments (1 for 0).This patch retrieves
Array#take(n)behaviour without breaking the AR version oftake.Note that I didn't touch
take!method because Ruby Array does not havetake!.So
takecan take an argument buttake!can not take an argument after this change.I think it's acceptable here, but I'd mention that the API would look a little bit inconsistent.