Revert work arounds for upstream Ruby 2.2.0 kwargs bug #19215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe you can also update the |
|
Sure @robin850, that's a good idea. |
gsamokovarov
force-pushed
the
revert-ruby-2-2-0-kwarg-crash-workarounds
branch
from
544f56e
to
fae84cc
Compare
| # default_headers from being a keyword argument. | ||
| def initialize(status = 200, header = {}, body = [], default_headers = self.class.default_headers) | ||
| # Beware of Ruby 2.2.0 bug https://bugs.ruby-lang.org/issues/10685 as it | ||
| # causes a segfault. |
There was a problem hiding this comment.
Let's just kill this comment, since the bug is fixed in 2.2.1
gsamokovarov
force-pushed
the
revert-ruby-2-2-0-kwarg-crash-workarounds
branch
from
fae84cc
to
8ed0b89
Compare
The bug caused a segfault and you can find more info about it at: https://bugs.ruby-lang.org/issues/10685. We did a couple of work arounds, but 2.2.1 rolled out and those aren't needed anymore. Here are the reverted commits: - Revert "Work around for upstream Ruby bug rails#10685", commit 707a433. - Revert "Fix segmentation fault in ActionPack tests", commit 22e0a22. I'm also bumping the Ruby version check to 2.2.1 to prevent future segfaults.
sgrif
added a commit
that referenced
this pull request
Mar 5, 2015
…rash-workarounds Revert work arounds for upstream Ruby 2.2.0 kwargs bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug caused a segfault and you can find more info about it at:
https://bugs.ruby-lang.org/issues/10685.
We did a couple of work arounds, but 2.2.1 rolled out and those aren't
needed anymore.
Here are the reverted commits:
commit 707a433.
commit 22e0a22.
Poking @eileencodes and @jeremy.