More docs on tagged logging #19236
Merged
More docs on tagged logging #19236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention that tags can also come from a Proc that accepts the request object or something's to_s method
| @@ -7,6 +7,9 @@ | |||
| module Rails | |||
| module Rack | |||
| # Sets log tags, logs the request, calls the app, and flushes the logs. | |||
| # | |||
| # Log tags can be an Array containing: methods that the <tt>request</tt> object responds to, a Proc | |||
There was a problem hiding this comment.
Looking at the code below, "Log tags" in this context could be called +taggers+ right?
There was a problem hiding this comment.
Just repurposing existing terminology in the docs. "Log tags" is more clear, I think. When I hear the word "taggers" I think of people who do graffiti or work in the garment industry.
There was a problem hiding this comment.
@sshaw yea that's true but since these docs are close to the source it's still nice to know where the "Log tags" are stored. What about: Log tags (+taggers+) can be ...
senny
added a commit
that referenced
this pull request
Apr 24, 2015
More docs on tagged logging [ci skip]
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention that tags can also come from a Proc that accepts the request object, or something's to_s method