-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new-line to the end of route method generated code. #19387
Conversation
Fix regression on route method that was added by bac812a. The regression was that when calling the `route` method, we were not appending a \n anymore. [fixes rails#19316]
This fixes the bug, but it still means that there is a slight (inconsequential?) difference in behavior from 4.2.0. The scaffold generator used to add an extra newline; now it does not. 4.2.0 after running Rails.application.routes.draw do
resources :users
resources :posts
end 4.2.1: Rails.application.routes.draw do
resources :users
resources :posts
end Again, this is just a whitespace difference. No big deal? (I think I actually prefer the new behavior.) |
👍 |
Sounds 👍 |
Add a new-line to the end of route method generated code.
Add a new-line to the end of route method generated code. Conflicts: railties/CHANGELOG.md
Add a new-line to the end of route method generated code. Conflicts: railties/CHANGELOG.md
Add a new-line to the end of route method generated code.
Add a new-line to the end of route method generated code.
Thanks for doing this @arthurnn - been slammed at work for the past few days |
this was backported to 4-1-stable too 836d1fd , and it is on the 4.1.10 release. @pixeltrix no worries bro. |
Fix regression on route method that was added by
bac812a. The regression was that when
calling the
route
method, we were not appending a \n anymore.[fixes #19316]
review @rafaelfranca @pixeltrix