Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog entry for removal of RACK_ENV fallback #19411

Merged
merged 1 commit into from
Mar 19, 2015
Merged

Changelog entry for removal of RACK_ENV fallback #19411

merged 1 commit into from
Mar 19, 2015
+7 −0

Conversation

dmathieu
Copy link
Contributor

arthurnn
arthurnn reviewed Mar 19, 2015
View reviewed changes
railties/CHANGELOG.md
@@ -1,3 +1,10 @@
* Don't fallback to using `RACK_ENV` when `RAILS_ENV` is not present.

RACK_ENV does not have the same signification as RAILS_ENV, and cannot be used as a fallback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/signification/meaning

(also can you add a [skip ci] to the message?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

arthurnn pushed a commit that referenced this pull request Mar 19, 2015
Merge pull request #19411 from dmathieu/rack_env_changelog
b19990c 
Changelog entry for removal of RACK_ENV fallback
@arthurnn arthurnn merged commit b19990c into rails:master Mar 19, 2015
@arthurnn
Copy link
Member

thanks

jeremy added a commit that referenced this pull request Mar 20, 2015
@jeremy
Revert "Merge pull request #19411 from dmathieu/rack_env_changelog"
a4e7a6f 
Preserving RACK_ENV behavior.

This reverts commit b19990c, reversing
changes made to ac291b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmathieu @arthurnn