Fix handling of empty X_FORWARDED_HOST header. #19433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an empty X_FORWARDED_HOST header would cause Actiondispatch::Http:URL.raw_host_with_port to return nil, causing Actiondispatch::Http:URL.host to raise a NoMethodError.
|
Patch looks good, but why |
|
It was sent by a badly behaved client. This caused the rails app to 500 instead of redirect when attempting to handle the bad request. |
rafaelfranca
added a commit
that referenced
this pull request
Mar 20, 2015
…eader Fix handling of empty X_FORWARDED_HOST header.
rafaelfranca
added a commit
that referenced
this pull request
Mar 20, 2015
…eader Fix handling of empty X_FORWARDED_HOST header.
rafaelfranca
added a commit
that referenced
this pull request
Mar 20, 2015
…eader Fix handling of empty X_FORWARDED_HOST header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an empty X_FORWARDED_HOST header would cause
Actiondispatch::Http:URL.raw_host_with_port to return nil, causing
Actiondispatch::Http:URL.host to raise a NoMethodError.
I ran into this bug on 3.2, so it might make sense to backport this to
-stablebranches.