Check subtype limit before using the default limit #19447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -560,7 +560,7 @@ def fetch_type_metadata(column_name, sql_type, oid, fmod) | |||
| simple_type = SqlTypeMetadata.new( | |||
| sql_type: sql_type, | |||
| type: cast_type.type, | |||
| limit: cast_type.limit, | |||
| limit: cast_type.try(:subtype).try(:limit) || cast_type.limit, | |||
There was a problem hiding this comment.
I think (cast_type.subtype ? cast_type.subtype.limit : cast_type_limit) is preferable over try here (unless cast_type does not always respond to .subtype)
There was a problem hiding this comment.
Yes, please avoid using try in the Rails codebase. Please also avoid ternaries.
|
Let's just delegate |
As described here rails#19420. When using the Postgres BigInt[] field type the big int value was not being translated into schema.rb. This caused the field to become just a regular integer field when building off of schema.rb. This fix will address this by delegating the limit from the subtype to the Array type. rails#19420
jacob-daniel-waller
force-pushed
the
postgresql_big_int_array_schema_rb
branch
from
cb3daff
to
9bc4eb7
Compare
|
@sgrif - Thanks for the tip! Much simpler this way also. Let me know if what I did was the proper fix. |
sgrif
added a commit
that referenced
this pull request
Mar 22, 2015
…hema_rb Check subtype limit before using the default limit
|
Thanks! <3 |
carlosantoniodasilva
added a commit
to carlosantoniodasilva/rails
that referenced
this pull request
Mar 22, 2015
jonatack
pushed a commit
to jonatack/rails
that referenced
this pull request
Mar 24, 2015
sgrif
added a commit
that referenced
this pull request
Jul 27, 2015
…hema_rb Check subtype limit before using the default limit
|
Backported in 3a71142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here #19420. When using the Postgres BigInt[] field type the big int value was not being translated into schema.rb. This caused the field to become just a regular integer field when building off of schema.rb. This fix will addrees this by checking the subtype's limit first and if not found then defaulting to the limit. As in this case the subtype limit is correct.
#19420