Fix has_migrations? check in Rails::Engine #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
added a commit
that referenced
this pull request
Jul 3, 2011
Fix has_migrations? check in Rails::Engine
|
If this is broken in 3-1-stable, could you please submit a patch as well? :) Thanks! |
|
The check is also broken in 3-1-stable. However can you clarify the process required? I'm guessing I create a new branch off of 3-1-stable, cherry pick the commit and create a new pull request? |
|
Similarly, what is the current policy on commits to master making it into 3-1-stable? |
|
Yeah, create a new branch of 3-1-stable, cherry-pick both commits and send a new pull request with copy to me pls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the install:migrations rake task for an engine is added even if no migrations directory exists, due to a broken check in the has_migrations? method.