Fix referencing wrong aliases while joining tables of has many through association #19452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
association While joining table of has_many :through association, ActiveRecord will use the actual table name instead of through-join alias. It results with a wrong SQL and exception is raised. This only happens when calculation methods like #count is called. This issue is affecting Rails 4.1.x and 4.2.x as well.
carlosantoniodasilva
added a commit
to carlosantoniodasilva/rails
that referenced
this pull request
Mar 24, 2015
…ias-when-joining-tables-of-has-many-through-association Fix referencing wrong aliases while joining tables of has many through association
carlosantoniodasilva
added a commit
that referenced
this pull request
Mar 24, 2015
…hen-joining-tables-of-has-many-through-association Fix referencing wrong aliases while joining tables of has many through association
carlosantoniodasilva
added a commit
that referenced
this pull request
Mar 24, 2015
…hen-joining-tables-of-has-many-through-association Fix referencing wrong aliases while joining tables of has many through association
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jun 12, 2016
`construct_relation_for_association_calculations` pass a string value to `construct_join_dependency` when setting a string value in `from`. It should not pass a string value, but always `joins_values`. Related rails#14834, rails#19452. Fixes rails#24193.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #19276.
While joining table of has_many :through association, ActiveRecord will use the actual table name instead of through-join alias. It results with a wrong SQL and exception is raised. This only happens when calculation methods like #count is called.
This bug is affecting Rails 4.1.x and 4.2.x as well.