[ci skip] Fix an object of reference
#19483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1510,7 +1510,7 @@ comments on articles. | |||
|
|
|||
| We're going to see the same generator that we used before when creating | |||
| the `Article` model. This time we'll create a `Comment` model to hold | |||
| reference of article comments. Run this command in your terminal: | |||
| reference to an article. Run this command in your terminal: | |||
There was a problem hiding this comment.
I think I like better the way it was before.
There was a problem hiding this comment.
In rails guide about associations, I think reference has special meaning. reference is equivalent to belongs_to. So I feel
Commentmodel to hold reference of article comments
means Comment model belongs_to article comments.
If this sentence means that creating Comment model to persist article comments, maybe it is better to write that ... create a Comment model to hold article comments.
There was a problem hiding this comment.
I think it's fine to say reference here. For me the use of the word reference here isn't special (no backticks), but sets up the reference coming in migration nicely.
zzak
pushed a commit
that referenced
this pull request
Mar 29, 2015
[ci skip] Fix an object of `reference`
|
thanks for your review ❤️ |
yui-knk
added a commit
to yasslab/railsguides.jp
that referenced
this pull request
Mar 30, 2015
Fix original docs via rails/rails#19483 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenthas reference to an article, orCommandhas a comment of an article.In this context
referenceshould be highlighted.