Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Active Record Validations guide fixes #19507

Merged
merged 1 commit into from
Mar 25, 2015

Conversation

jonatack
Copy link
Contributor

  • Remove deprecated []=
  • Fix duplicate errors#add example. The second code example was
    originally []=, replace it with [] <<.
  • Improve explanations for errors#add and errors#full_messages

Follow-up to PR #19457 (closed after borking my git history ⚡).
Apologies for the duplicate PR.

cc @kaspth

- Remove deprecated `[]=`

- Fix duplicate `errors#add` example. The second code example was
originally `[]=`, replace it with `[] <<`.

- Improve explanations for `errors#add` and `errors#full_messages`

Follow-up to PR rails#19457 (closed after borking my git history). Apologies
for the duplicate PR.

cc @kaspth
kaspth added a commit that referenced this pull request Mar 25, 2015
[skip ci] Active Record Validations guide fixes
@kaspth kaspth merged commit 0f76ea6 into rails:master Mar 25, 2015
@jonatack jonatack deleted the ar-validations-guide-fixes branch March 25, 2015 08:06
@kaspth
Copy link
Contributor

kaspth commented Mar 25, 2015

Well done ❤️

@jonatack
Copy link
Contributor Author

Thanks @kaspth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants