Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Unify the code comment in ActionView::Renderer#render_template... #19535

Merged
merged 1 commit into from
Mar 27, 2015
Merged

[ci skip] Unify the code comment in ActionView::Renderer#render_template... #19535

merged 1 commit into from
Mar 27, 2015

Conversation

JuanitoFatas
Copy link
Contributor

After this Pull Request, comments of render_template and render_partial are symmetry.

# Direct access to template rendering.
def render_template(context, options) #:nodoc:
  TemplateRenderer.new(@lookup_context).render(context, options)
end

# Direct access to partial rendering.
def render_partial(context, options, &block) #:nodoc:
  PartialRenderer.new(@lookup_context).render(context, options, block)
end

@kaspth
Copy link
Contributor

kaspth commented Mar 26, 2015

I don't understand why there are even comments here. The way they're written makes it sound like we're encouraging users to override the methods, which we don't because they're private API.

What do you think, @rafaelfranca?

senny added a commit that referenced this pull request Mar 27, 2015
[ci skip] Unify the code comment in ActionView::Renderer#render_template...
@senny senny merged commit d5943ab into rails:master Mar 27, 2015
@senny
Copy link
Member

senny commented Mar 27, 2015

@kaspth the methods are #:nodoc'd and not targeting users. How useful they are is certainly debatable but they were introduced by the original author of that piece (b735761). I think it's ok to keep them.

@kaspth
Copy link
Contributor

kaspth commented Mar 27, 2015

All good 😁

Kasper

Den 27/03/2015 kl. 08.40 skrev Yves Senn notifications@github.com:

@kaspth the methods are #:nodoc'd and not targeting users. How useful they are is certainly debatable but they were introduced by the original author of that piece (b735761). I think it's ok to keep them.


Reply to this email directly or view it on GitHub.

@JuanitoFatas JuanitoFatas deleted the doc/av-comment branch March 27, 2015 07:50
@JuanitoFatas
Copy link
Contributor Author

Thanks! @senny and @kaspth 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants