use singular table name if pluralize_table_names is setted as false whil... #19652
Conversation
|
@meinac could you add a test-case to prevent against regressions? |
|
@senny I've created a test case for this situation. |
| @@ -12,6 +12,7 @@ class ReferencesForeignKeyTest < ActiveRecord::TestCase | |||
| teardown do | |||
| @connection.drop_table "testings", if_exists: true | |||
| @connection.drop_table "testing_parents", if_exists: true | |||
| @connection.drop_table "testing", if_exists: true | |||
There was a problem hiding this comment.
can you move that drop_table into an ensure clause for the specific test. No need to run it for every other test if the table is only created in one of em.
|
@senny what about this? |
| assert_equal "testing", fk.to_table | ||
| ensure | ||
| ActiveRecord::Base.pluralize_table_names = original_pluralize_table_names | ||
| @connection.drop_table "testing_parents" |
There was a problem hiding this comment.
let's add if_exists: true. The test could fail on any line in the begin block. The tables might not exists and this could hide errors.
There was a problem hiding this comment.
Aren't these two tables dropped in teardown already?
teardown do
@connection.drop_table "testings", if_exists: true
@connection.drop_table "testing_parents", if_exists: true
end
There was a problem hiding this comment.
I have to drop testing parent table here because I'm adding foreign key to it. If you don't drop it you can't drop testing table too.
|
@senny I believe this is ok now :) |
…hile creating foreign key test case for use singular table name if pluralize_table_names is setted as false while creating foreign key refactor references foreign key addition tests use singular table name while removing foreign key merge foreign key singular table name methods remove unnecessary drop table from test
|
I've remove drop table for testing_parents table because I'm removing foreign key from this table inside of the test case so don't need to drop this table before testing table |
…_bug use singular table name if pluralize_table_names is setted as false whil...
|
@meinac thank you. I'll look into a backport to |
…_bug use singular table name if pluralize_table_names is setted as false whil... Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
use singular table name if pluralize_table_names is setted as false while creating foreign key
Closes #19643