[ci skip] Description inside Signed and Encrypted CookieJars added #19823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -454,12 +454,16 @@ def initialize(parent_jar, key_generator, options = {}) | |||
| @verifier = ActiveSupport::MessageVerifier.new(secret, digest: digest, serializer: ActiveSupport::MessageEncryptor::NullSerializer) | |||
| end | |||
|
|
|||
| # Returns the value of the cookie by +name+ if it is untampered, | |||
| # returns +nil+ otherwise and if no such cookie exists. | |||
There was a problem hiding this comment.
This makes it sound like nil is only returned if the cookie has been tampered with AND the cookie does not exist. Is that technically correct? Did you mean "or" instead of "and"?
There was a problem hiding this comment.
Yeah, I think you are right. It should be 'or' instead of 'and'.
|
Could you squash your commits? |
|
Sure. Its done 😄 !! |
rafaelfranca
added a commit
that referenced
this pull request
Apr 23, 2015
[ci skip] Description inside Signed and Encrypted CookieJars added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.