Activesupport dependencies failing test #19897
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a test case that doesn't start with
test_
in AS/test. So I renamed it, then I found that it's actually not passing.The test case expects a
NameError
when AS tries to autoloadModuleFolder::NestedClass::Object
, but in fact it autoloadsModuleFolder::NestedClass
and returns::Object
withwarning: toplevel constant Object referenced by ModuleFolder::NestedClass::Object
.I'm not sure what is the desired fix here. What do you think, @fxn?