Unlock sneakers adapter version #19907
Conversation
|
If we no longer need a prerelease, I guess we should follow the other adapters lead, and drop the version constraint entirely. Before we deal with that, however, we probably need to fix the test failure. 😄 |
|
Ok, i will try to fix tests |
artofhuman
force-pushed
the
sneakers-update
branch
3 times, most recently
from
fd162ef
to
1498965
Compare
artofhuman
changed the title
artofhuman
force-pushed
the
sneakers-update
branch
from
1498965
to
22abd4a
Compare
|
AJ section is green https://travis-ci.org/rails/rails/builds/60330170 |
| @@ -84,7 +84,7 @@ def bunny_publisher | |||
| end | |||
|
|
|||
| def bunny_queue | |||
| @queue ||= bunny_publisher.exchange.channel.queue "integration_tests", durable: true | |||
| @queue ||= bunny_publisher.send(:exchange).channel.queue "integration_tests", durable: true | |||
There was a problem hiding this comment.
Looks like exchange has been removed from the public API. Do you think there's any chance that we can implement this without reaching into the object? If not, maybe we can persuade the sneakers maintainer to consider making it public again...
/cc @jondot
There was a problem hiding this comment.
Yes. exchange moved to private api in this commit jondot/sneakers@c331d11
There was a problem hiding this comment.
Hey guys, I can explore exposing the exchange back. Thanks for notifying me!
Will get back with updates soon
There was a problem hiding this comment.
Done. Exchange moved back, and released new v1.0.4 to reflect this (and other previous improvements).
Feel free to LMK if there's anything more I can do to help, thanks!
artofhuman
force-pushed
the
sneakers-update
branch
from
22abd4a
to
ee68786
Compare
|
@artofhuman thank you 💛 |
No description provided.