Previews when mail wasn't called (NullMail instances).
#19917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened a PR as I'm not sure about the wording:
I didn't want to use the term Secondly, I'm not sure the @pixeltrix @rafaelfranca thoughts? |
|
Maybe:
? And I think we can remove the |
|
Maybe:
As NullMail instance gets created if |
|
@senny as @rafaelfranca said just remove the debug output and |
While this was true before when every `dd` had a value, this patch makes sure that everything keeps lining up even when the `dd` node is blank.
senny
force-pushed
the
preview_null_mail
branch
from
95c2734
to
767d601
Compare
senny
added a commit
that referenced
this pull request
Apr 28, 2015
Previews when `mail` wasn't called (NullMail instances).
senny
added a commit
that referenced
this pull request
Apr 28, 2015
Previews when `mail` wasn't called (NullMail instances). Conflicts: actionmailer/CHANGELOG.md
senny
added a commit
that referenced
this pull request
Apr 28, 2015
Previews when `mail` wasn't called (NullMail instances). Conflicts: actionmailer/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19849
This patch makes it possible to preview
NullMailinstances. It reuses the same template to keep a consistent output but replaces the body iframe with help and debug output:It was also necessary to get the definition list to align properly when blank values are involved:
Before:
After:
