Fix for activerecord join dependency instantiate bug #19938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case that assets the new behavior? |
|
@rafaelfranca I've created a test case for testing the behaviour. By the way, data model of the original issue is wrong to me but even if the data model is wrong rails should handle relations correctly so this patch does this. |
| @@ -0,0 +1,5 @@ | |||
| class Mentor < ActiveRecord::Base | |||
|
|
|||
use only object_id instead parent class and parent id test cases assert_equal use table name in references fix minor problems
|
@rafaelfranca thanks for your response, I've fixed minor problems. |
|
@rafaelfranca did you have a chance to look into this? |
sgrif
added a commit
that referenced
this pull request
Oct 20, 2015
This is a separate commit, as it is not just a changelog conflict. Want to point out the changes in the code
sgrif
added a commit
that referenced
this pull request
Oct 20, 2015
Fix for activerecord join dependency instantiate bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix closes #19896