deprecation warning clarifies which field value is invalid #19956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecation warning currently says "You attempted to assign a value which is not explicitly `true` or `false` to a boolean column" but doesn't say *which* column or value is the culprit. This patch makes it easier to track down mistakes and correct them by clearly saying what value was not found in the list of acceptable TRUE and FALSE values. (Unfortunately it doesn't know which *field* was being set, just what *value*, but it's much better than it was.)
|
+1 |
|
So value is only going to be true or false in this case, we don't know the column at the time. We can get the column lazily, but that may mean executing a sql query. |
|
Nope. value is the entered value. Trust me, I hacked my gem and it showed me I was trying to set a boolean to "Oil Change" :-) |
rafaelfranca
added a commit
that referenced
this pull request
May 4, 2015
deprecation warning clarifies which field value is invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecation warning currently says "You attempted to assign a value which is not explicitly
trueorfalseto a boolean column" but doesn't say which column or value is the culprit. This patch makes it easier to track down mistakes and correct them by clearly saying what value was not found in the list of acceptable TRUE and FALSE values.(Unfortunately it doesn't know which field was being set, just what value, but it's much better than it was.)