Use Module.prepend instead of alias_method and unify behavior of all Numeric extensions

[imanel]

This is a follow-up pull request to #19434 - now that Ruby 2.2.2 is out we can switch to #prepend.

/cc @rafaelfranca @kirs

[imanel]

Build is passing - not sure why travis is reporting it's still building.

[kirs]

Looks good 👍
Hope we could use refinements at some point.

On Wednesday, May 6, 2015, Bernard Potocki notifications@github.com wrote:

Build is passing - not sure why travis is reporting it's still building.

—
Reply to this email directly or view it on GitHub
#20038 (comment).

[imanel]

@rafaelfranca ?

[rafaelfranca]

We can't change this too easily because there aliases are public API. We could deprecate them but I'm not sure if we will have any improvement on doing so.

[rafaelfranca]

Oops, I should not have closed.

@carlosantoniodasilva @senny @chancancode WDYT?

[carlosantoniodasilva]

I think those methods only existed due to the alias method chain stuff, so I'd be game to deprecating them now that we can use prepend. Extremely low priority thing to do, though.

On another topic, it freaks me out moving code like that because of indent =(, I wonder if declaring the modules as module ActiveSupport::NumericWithFormat wouldn't make it easier.

[imanel]

@carlosantoniodasilva removed indentation, added deprecated to_formatted_s. I've used def instead of alias so we can still overwrite it in BigDecimal.

[kaspth]

Why can't this just be Numeric.prepend?

[imanel]

I would be delighted to do so, but we've never overwritten Complex and Rational so I hesitated a little:

>> ObjectSpace.each_object(Class).select { |klass| klass < Numeric }
#=> [Complex, Rational, Bignum, Float, Fixnum, Integer]

and it looks like it will not work properly:

>> ActiveSupport::NumberHelper.number_to_percentage Complex(2,2)
#=> RangeError: can't convert 2+2i into Float

[sgrif]

This seems like a fine improvement from the implementation side. If we're ever going to deprecate the aliases which were really only there for implementation reasons, Rails 5 is the version to do it.