removing unused and already required require's #20111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom test - Does not include EnvHelpers and the require is not needed path generation test - require abstract_unit which has . rails/all requires rails and corresponding
|
Thank you. I'm merging this one but I'd ask you to not send more pull requests like this one. They are not easy to review and don't give any real benefits for the framework, so I'd consider they cosmetic changes. I know you want to contribute for the framework so I'd love to direct you with changes that would benefits more the framework. |
rafaelfranca
added a commit
that referenced
this pull request
May 11, 2015
removing unused and already required require's
|
@rafaelfranca thank you. That will be great if you want me to focus on a particular area. Happy to take it up. Let me knw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom test - Does not
include EnvHelpersor helpers from env_helpers and the require is not neededpath generation test -
require abstract_unitwhich hasrequire rails/all. It requires rails and corresponding.