[ci skip] Remove comments about Rails 3.1 #20113
Conversation
| # contains the version numbers of all the migrations applied. | ||
| # | ||
| # As a result, it is now possible to add migration files that are numbered | ||
| # It is possible to add migration files that are numbered |
There was a problem hiding this comment.
This sounds weird as an opening sentence under the sub-heading.
However, I think this whole paragraph is really still describing how the 2.1+ solution fixes a shortcoming in the old approach... so it can probably go too.
|
👍 |
claudiob
force-pushed
the
remove-rails31-refs
branch
from
b43e2c1
to
8b145a8
Compare
|
@matthewd Removed the whole paragraph. On a separate note, as I was reading that file, I saw this: # If you'd prefer to use numeric prefixes, you can turn timestamped migrations
# off by setting:
#
# config.active_record.timestamped_migrations = false
#
# In application.rb.Is this an actual configuration that we want to maintain in Rails 5, 6, 7, or was it just a temporary patch for people upgrading to Rails 3, and can be removed in Rails 5? |
| @@ -8,8 +8,7 @@ module ActionController | |||
| # POST requests without having to specify any root elements. | |||
| # | |||
| # This functionality is enabled in +config/initializers/wrap_parameters.rb+ | |||
| # and can be customized. If you are upgrading to \Rails 3.1, this file will | |||
| # need to be created for the functionality to be enabled. | |||
| # and can be customized. | |||
There was a problem hiding this comment.
Already documented here: https://github.com/rails/rails/blame/master/guides/source/3_1_release_notes.md#L119
Stems from rails#20105 (comment) where @senny said: > From my point of view, all the docs (guides, API) are version bound. > They should describe that version and continue to be available when newer versions are released. > The cross referencing can be done by the interested user.
claudiob
force-pushed
the
remove-rails31-refs
branch
from
8b145a8
to
271a552
Compare
| # your plugin's +lib+ folder (similar to how we specify a +Railtie+): | ||
| # If you want a gem to behave as an engine, you have to specify an +Engine+ | ||
| # for it somewhere inside your plugin's +lib+ folder (similar to how we | ||
| # specify a +Railtie+): |
There was a problem hiding this comment.
Our upgrade guide starts with "Upgrading from Rails 3.0 to Rails 3.1".
This is also probably so old, we don't need to describe it anymore.
|
@senny I think everything relevant is covered, check my comments above 🎀 |
|
👍 over here! |
[ci skip] Remove comments about Rails 3.1
Stems from #20105 (comment) where @senny said:
@senny, merge/reject as you wish… I don't have a strict preference about this.