Add more detailed comment about _assign_attribute method [ci skip] #20131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,8 @@ def _assign_attributes(attributes) # :nodoc: | |||
| assign_multiparameter_attributes(multi_parameter_attributes) unless multi_parameter_attributes.empty? | |||
| end | |||
|
|
|||
| # Re-raise with the ActiveRecord constant in case of an error | |||
| # Tries to assign given value to given attribute | |||
There was a problem hiding this comment.
Missing . in the end of the line
fix minor problems
|
@rafaelfranca you were always helpful for my pull requests to find the best way, thank you. I've fixed problems about this pr. |
|
You are welcome. Thank YOU for improving Rails ❤️ |
rafaelfranca
added a commit
that referenced
this pull request
May 12, 2015
Add more detailed comment about _assign_attribute method [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.