Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ActionDispatch::Journey::Routes#empty? #20191

Merged
merged 2 commits into from
May 18, 2015

Conversation

juggernaut-
Copy link
Contributor

ActionDispatch::Routing::RouteSet has method "empty?", which is delegating to an instance of ActionDispatch::Journey::Routes, but latter has not this method. So the following code raises NoMethodError.

Rails.application.routes.empty?

@rafaelfranca
Copy link
Member

Could you add a test case?

@juggernaut-
Copy link
Contributor Author

Done.

rafaelfranca added a commit that referenced this pull request May 18, 2015
Added ActionDispatch::Journey::Routes#empty?
@rafaelfranca rafaelfranca merged commit bad30ed into rails:master May 18, 2015
rafaelfranca added a commit that referenced this pull request May 18, 2015
Added ActionDispatch::Journey::Routes#empty?
rafaelfranca added a commit that referenced this pull request May 18, 2015
Added ActionDispatch::Journey::Routes#empty?
@rafaelfranca
Copy link
Member

Thank you.

Backported at 1f1d8ec and 21abb6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants