Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postgresql DISTINCT requirement in pluck test #20413

Merged
merged 1 commit into from
Jun 2, 2015
Merged

Fix postgresql DISTINCT requirement in pluck test #20413

merged 1 commit into from
Jun 2, 2015

Conversation

kddnewton
Copy link
Contributor

Introduced in 4e63bde: SELECT DISTINCT, ORDER BY expressions must appear in select list
id was not a selected DISTINCT column, so it errored.

@seuros
Copy link
Member

seuros commented Jun 2, 2015

pluck should not add another column. we should remove the order by instead.

@kddnewton
Copy link
Contributor Author

Sure... that's fine.

senny added a commit that referenced this pull request Jun 2, 2015
Fix postgresql DISTINCT requirement in pluck test
@senny senny merged commit de412ee into rails:master Jun 2, 2015
@senny
Copy link
Member

senny commented Jun 2, 2015

thanks 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants