[ci skip] fix the collection.clear guide
#20421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # keys to <tt>NULL</tt>. For, +has_many+ <tt>:through</tt>, the default | ||
| # strategy is +delete_all+. | ||
| # Deletes the +records+ supplied from the collection according to the strategy | ||
| # specified by the +:dependent+ option. If no +:dependent+ option is given, |
There was a problem hiding this comment.
I think it needs to use <tt> for symbols
There was a problem hiding this comment.
echo "+:dependent+" | rdoc --pipe still outputs <p><code>:dependent</code></p>
There was a problem hiding this comment.
Yes, for +:delete_all+ using the same idea you get <p><code>:delete_all</code></p>.
Improve the guide about `has_many` `collection.clear` to indicate the behavior for each dependent strategy according to `collection.delete_all`. Based on rails#17179, I changed the `collection.delete` docs to also clarify the default strategy for each `hm` and `hm:t` associations. Fixes rails#20170.
repinel
force-pushed
the
fix-clear-guides-and-related-api-docs
branch
from
77b0241
to
efa1648
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jun 3, 2015
…pi-docs [ci skip] fix the `collection.clear` guide
rafaelfranca
added a commit
that referenced
this pull request
Jun 3, 2015
…pi-docs [ci skip] fix the `collection.clear` guide
|
@rafaelfranca Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the guide about
has_manycollection.clearto indicate the behavior for each dependent strategy according tocollection.delete_all.Based on #17179, I changed the
collection.deletedocs to also clarify the default strategy for eachhmandhm:tassociations.Fixes #20170.