Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when loading fixture with belongs_to association defined in abstract base class #20437

Merged
merged 1 commit into from
Jun 9, 2015

Conversation

pwnall
Copy link
Contributor

@pwnall pwnall commented Jun 4, 2015

This fixes #20436 for edge rails.

I'm looking forward to your feedback. ❤️

@mrageh
Copy link
Contributor

mrageh commented Jun 4, 2015

@pwnall this pr looks identical to #20438. Does this pr need to be closed?

@pwnall
Copy link
Contributor Author

pwnall commented Jun 5, 2015

@Adam89 This is for edge Rails, #20438 is for the 4.2 branch.

rafaelfranca added a commit that referenced this pull request Jun 9, 2015
Fix crash when loading fixture with belongs_to association defined in abstract base class
@rafaelfranca rafaelfranca merged commit c0c3ef3 into rails:master Jun 9, 2015
rafaelfranca added a commit that referenced this pull request Jun 9, 2015
Fix crash when loading fixture with belongs_to association defined in abstract base class
@rafaelfranca
Copy link
Member

Backported as 345e71d

@pwnall
Copy link
Contributor Author

pwnall commented Jun 9, 2015

@rafaelfranca Thank you!

@mrageh
Copy link
Contributor

mrageh commented Jun 12, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining 'belongs_to' in abstract class breaks subclass model fixtures.
3 participants