-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use our own runner for Rails framework components bin/test
#20480
Conversation
LGTM |
Are we going to use them on the travis setup too? |
LGTM too. Are you planning to add the Active Record etc. runners here or in another pr? |
LGTM |
@kaspth I'll investigate adding the runner to AR. The most obvious problem at the moment is that As far as I can see things are more complicated for Railties and Active Job. |
This makes it possible to easily get the runner working with existing setups that rely on `active_support/testing/autorun.rb`.
This adds a script `bin/test` to most Rails framework components. The script uses the rails minitest plugin to augment the runner. See rails#19571 for details about the plugin. I did not yet add `bin/test` for activerecord, activejob and railties. These components rely on specific setup performed in the rake-tasks.
@rafaelfranca what do you think about changing all the superclasses to get it working with |
use our own runner for Rails framework components `bin/test`
Very cool! 😄 Kasper On 12. jun. 2015 17.20 +0200, Yves Sennnotifications@github.com, wrote:
|
* Since rails#20480, it come to be used `bin/test`. * For newbies, bin/test is easier to understand than rake task.
The minitest plugin for Rails 5 has some fantastic improvements. Would be nice to have it's features available in Rails itself.
This is a quick proof of concept to integrate the runner. The components Active Record, Railties and Active Job have been skipped for now because they rely on additional setup performed in the Rake tasks.
Interested to hear your thoughts.