Add require to ensure Time#advance works without implicit required #20534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| 2.1.4 | |||
There was a problem hiding this comment.
Seems like this file added in git commit. Can you remove this ?
|
@arunagw Anything I can do to move this along? |
|
cc/ @senny |
senny
added a commit
that referenced
this pull request
Sep 7, 2015
Add require to ensure Time#advance works without implicit required
senny
added a commit
that referenced
this pull request
Sep 7, 2015
Add require to ensure Time#advance works without implicit required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Using
Time#advancewithout first loadingactive_support/core_ext/date/calculations(like Padrino may do) will result in an exception being raised.I've created a testable code snippet at https://gist.github.com/qnm/63799aeb77cb6b9157f7
What I expect to happen
I expect the time to be advanced according to the supplied arguments
What actually happens
An exception is raised