-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gotcha to RDoc of collection_check_boxes #20548
Add gotcha to RDoc of collection_check_boxes #20548
Conversation
# ==== Gotcha | ||
# | ||
# The HTML specification says when nothing is select on a collection of radio buttons | ||
# web browsers do not send any value to server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which spec?
Also, probably:
The HTML specification says that web browsers should not send any value when no selection is made for a collection of radio buttons.
or
When no selection is made for a collection of radio buttons most web browsers will not send any value, based on the HTML specification.
00bd317
to
a251514
Compare
@zzak thanks for the review. |
Please wrap it at 80 chars, we may possibly want to consider the following: From 8.1.2.4 from RFC1866
|
a251514
to
58a75ff
Compare
@zzak I updated to wrap it on 80 chars. Actually we are adding docs about collection of checkboxes and not radio buttons, yeah on my first commit this was sent as radio buttons, my mistake sorry 😞 . As you can see on on 8.1.2.3 from RFC1866 we do not have the same doc of the radio buttons. So I rewrote the first paragraph. This makes senses to you? Or you think we have some RFC that describes this behavior? |
This looks good to me, thanks for your contribution @maurogeorge! |
…c-gotcha Add gotcha to RDoc of collection_check_boxes
Thanks @zzak for the review and merge |
The
collection_check_boxes
generates a default hidden input to prevent a gotcha, like the file_field does.This PR add a RDoc to this.