raise ActiveModel::MissingAttributeError when trying to access a relationship without the foreign key attribute #20578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcrec1
changed the title
|
@sgrif is this ok? |
| @@ -107,8 +107,7 @@ def target_id | |||
| end | |||
|
|
|||
| def stale_state | |||
| result = owner._read_attribute(reflection.foreign_key) | |||
| result && result.to_s | |||
There was a problem hiding this comment.
I would keep this as a separate line. This change would cause nil to be turned into a string, which I believe could potentially cause extra queries.
There was a problem hiding this comment.
Ok, will change this.
|
One comment, this seems fine otherwise. |
…tionship without the foreign key attribute fixes regression reported on rails#20253 ActiveRecord::Base#[] was not used cause of 8b95420
sgrif
added a commit
that referenced
this pull request
Jun 16, 2015
raise ActiveModel::MissingAttributeError when trying to access a relationship without the foreign key attribute
|
Thanks! ❤️ |
|
Actually, the original issues was a regression in 4.2.x. Can we backport this patch to 4-2-stable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes regression reported on #20253
ActiveRecord::Base#[] was not used cause of 8b95420