Change documentation for collection.build and collection.create [ci-skip] #20652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1519,20 +1519,30 @@ conditions exists in the collection. It uses the same syntax and options as | |||
|
|
|||
| ##### `collection.build(attributes = {}, ...)` | |||
|
|
|||
| The `collection.build` method returns one or more new objects of the associated type. These objects will be instantiated from the passed attributes, and the link through their foreign key will be created, but the associated objects will _not_ yet be saved. | |||
| The `collection.build` method returns a single or array of new objects of the associated type. The object(s) will be instantiated from the passed attributes, and the link through their foreign key will be created, but the associated objects will _not_ yet be saved. | |||
There was a problem hiding this comment.
"...returns a single object or array of objects for the associated type."
There was a problem hiding this comment.
Suggestions:
- "a single object or an array of"
- "of the associated type"
- no comma after "attributes"
"The collection.build method returns a single object or an array of new objects of the associated type. The object(s) will be instantiated with the passed attributes and the link through their foreign key will be created, but the associated objects will not yet be saved."
|
@ankit1910 I can't see the final version, where is it? |
|
@ankit1910 Thanks! |
zzak
pushed a commit
that referenced
this pull request
Jun 27, 2015
Change documentation for collection.build and collection.create [ci-skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.