Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pluck documentation on uniq #20708

Merged
merged 1 commit into from
Jun 26, 2015
Merged

Conversation

sikachu
Copy link
Member

@sikachu sikachu commented Jun 26, 2015

This is to show users that they can chain .uniq and .pluck to get the DISTINCT column result. They don't have to do DISTINCT column themselves.

I'm submitting this as a PR as this changes the way we represent this method to users. I think it's fine, as we already show that this method supports SQL statement below.

This is to show users that they can chain `.uniq` and `.pluck` to get
the `DISTINCT column` result. They don't have to do `DISTINCT column`
themselves.
@zzak
Copy link
Member

zzak commented Jun 26, 2015

@sikachu 👍 Thank you! <3

zzak pushed a commit that referenced this pull request Jun 26, 2015
Update .pluck documentation on uniq
@zzak zzak merged commit 4b4075b into rails:master Jun 26, 2015
@sikachu sikachu deleted the update-pluck-suggestion branch June 27, 2015 01:49
@bogdan
Copy link
Contributor

bogdan commented Jun 27, 2015

As I remember uniq is not very welcome on relation. We'd better use distinct instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants