Stop using deprecated render :text in test
#20923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # variant.any(:tablet, :phablet){ render text: "any" } | ||
| # variant.phone { render text: "phone" } | ||
| # variant.any(:tablet, :phablet){ render body: "any" } | ||
| # variant.phone { render body: "phone" } |
There was a problem hiding this comment.
Would avoid using the body: option in docs. Makes sense to use plain: if we're rendering text.
There was a problem hiding this comment.
plain: actually forces text/plain (i.e. it does not care if it's overridden by respond_to block)
I have a mixed feeling after I found out about that, but it has to be body: in this example.
There was a problem hiding this comment.
Ah right, due to the respond_to blocks. Maybe using html: is clearer, then.
sikachu
force-pushed
the
silence-render-text-warning
branch
from
01e32b6
to
d4d4b57
Compare
This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`.
sikachu
force-pushed
the
silence-render-text-warning
branch
from
d4d4b57
to
8cb8ce9
Compare
matthewd
added a commit
that referenced
this pull request
Jul 18, 2015
Stop using deprecated `render :text` in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will silence deprecation warnings when running test suite.
Most of the test can be changed from
render :textto render:plainorrender :bodyright away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned fromrender :body.