Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicity in tests #21106

Merged
merged 1 commit into from
Aug 21, 2015
Merged

Remove duplicity in tests #21106

merged 1 commit into from
Aug 21, 2015

Conversation

amitsuroliya
Copy link
Contributor

test_ignores_leading_slash is duplicating test_default_setup.

@pixeltrix
Copy link
Contributor

@strzalek can you remember why you added all the leading slashes in 8412886 - that commit is the original source of the duplication.

@lukaszx0
Copy link
Member

lukaszx0 commented Aug 3, 2015

Nope. I was notoriously fixing routings test so I'm assuming that this one slipped though and it's safe to remove it.

pixeltrix added a commit that referenced this pull request Aug 21, 2015
@pixeltrix
Merge pull request #21106 from amitsuroliya/fix_routing_test
95cb2e3 
Remove duplicity in tests
@pixeltrix pixeltrix merged commit 95cb2e3 into rails:master Aug 21, 2015
@pixeltrix
Copy link
Contributor

Most of these routing tests in controller are legacy tests from 2.3 and earlier before the Action Dispatch extraction so I think eliminating as many as we can is a good thing.

@amitsuroliya
Copy link
Contributor Author

thanks @pixeltrix. I will looking into it and eliminate, if i found any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pixeltrix pixeltrix

Labels
actionpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amitsuroliya @pixeltrix @lukaszx0 @rafaelfranca