Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use server_info[:version] instead of info[:version] #21112

Merged
merged 1 commit into from
Aug 4, 2015

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Aug 3, 2015

Because info[:version] is a client version, the server version is server_info[:version].

Because `info[:version]` is a client version, the server version is
`server_info[:version]`.
@meinac
Copy link
Contributor

meinac commented Aug 4, 2015

It's true, if there is somebody want to see definition of these functions, here is the info and server info functions.

rafaelfranca added a commit that referenced this pull request Aug 4, 2015
Should use `server_info[:version]` instead of `info[:version]`
@rafaelfranca rafaelfranca merged commit 57989c5 into rails:master Aug 4, 2015
@rafaelfranca
Copy link
Member

Awesome! Thank you guys

rafaelfranca added a commit that referenced this pull request Aug 4, 2015
Should use `server_info[:version]` instead of `info[:version]`
rafaelfranca added a commit that referenced this pull request Aug 4, 2015
Should use `server_info[:version]` instead of `info[:version]`
@kamipo kamipo deleted the fix_mysql2_version branch August 5, 2015 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants