[ci skip] Fix broken link markup #21195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the anchor, that we are using right now works for me. |
senny
added a commit
that referenced
this pull request
Aug 11, 2015
[ci skip] Fix broken link markup
|
@brooksreese thank you 💛 I merged a slightly modified version that let's us keep the anchor: @arthurnn the issue was not the link itself but how it was presented on the guides page:
|
|
Thanks - the markup looks good now and the anchor worked when I clicked it. |
senny
added a commit
that referenced
this pull request
Aug 11, 2015
[ci skip] Fix broken link markup Conflicts: guides/source/working_with_javascript_in_rails.md
|
coolio.. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under section 5.1 (How Turbolinks Works) of the Working with javascript in rails guide, a link to PushState on the developer.mozilla site exists, but its markup is broken. Because of this, the link doesn't show the 'PushState' text as normal text in brackets and the url is displayed as a full url.
This commit fixes the broken markup so PushState text will be a hyperlink instead of the full url to the link.