Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins are generated with the version 0.1.0 #21258

Merged
merged 2 commits into from
Aug 16, 2015
Merged

Plugins are generated with the version 0.1.0 #21258

merged 2 commits into from
Aug 16, 2015

Conversation

unfunco
Copy link
Contributor

@unfunco unfunco commented Aug 16, 2015

The semantic versioning specification uses MAJOR.MINOR.PATCH – it would
make more sense to set the version to 0.1.0 for initial development
since a patch release cannot be created before a minor feature release.

The semantic versioning specification uses MAJOR.MINOR.PATCH – it would
make more sense to set the version to 0.1.0 for initial development
since a patch release cannot be created before a minor feature release.
@seuros
Copy link
Member

seuros commented Aug 16, 2015

Version 0 patch 1 ?

@rafaelfranca
Copy link
Member

Tests need to be updated

@unfunco
Copy link
Contributor Author

unfunco commented Aug 16, 2015

@seuros

Major: 0
Minor: 1
Patch: 0

From the semver.org FAQ:

How should I deal with revisions in the 0.y.z initial development phase?
The simplest thing to do is start your initial development release at 0.1.0 and then increment the minor version for each subsequent release.

guilleiguaran added a commit that referenced this pull request Aug 16, 2015
Plugins are generated with the version 0.1.0
@guilleiguaran guilleiguaran merged commit 6c014a4 into rails:master Aug 16, 2015
@unfunco
Copy link
Contributor Author

unfunco commented Aug 16, 2015

@rafaelfranca Tests updated. I ran the test suite from the railties directory and the first set ran fine, but the next set raised an error about ::ExecJS not being found (using rails/rails-dev-box). I can look deeper into that issue later if needed.

@guilleiguaran
Copy link
Member

thanks <3

@unfunco unfunco deleted the plugin-semver-update branch August 17, 2015 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants