Remove dead code #21298
Merged
Remove dead code #21298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The method is listed on http://api.rubyonrails.org not sure there are no external dependencies on it. The meaning of that method was changed with 267e5c8 I'll leave this one up to @tenderlove |
|
To clarify I was greping rails and strong_parameters to find this method used |
|
I don't think it is used anywhere. It was used in Rails 3.0 but it is not used anymore, it was public just for matter of consistence with the visibility it had before @tenderlove's patch. I'll just remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find any place that it is used, maybe we should remove it?