Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes [ci skip] #21312

Merged
merged 2 commits into from Aug 21, 2015
Merged

Small fixes [ci skip] #21312

merged 2 commits into from Aug 21, 2015

Conversation

piton4eg
Copy link
Contributor

No description provided.

@senny
Copy link
Member

senny commented Aug 21, 2015

PR just says small fixes but what exactly did you fix? The diff is quite big and it's hard to change what changes you made besides reformatting.

@senny senny added the docs label Aug 21, 2015
@piton4eg
Copy link
Contributor Author

@senny i just added hyphen between lists' titles and descriptions. It were like here: http://screencast.com/t/HjdFcxVvA (without delimeter)

@senny
Copy link
Member

senny commented Aug 21, 2015

I agree that the current formatting can be improved. What do you think about a bold header name followed by a colon? Something along the lines of:

  • X-Frame-Options: 'SAMEORIGIN' in Rails by default - allow framing on same domain. Set it to 'DENY' to deny framing at all or 'ALLOWALL' if you want to allow framing for all website.
  • X-XSS-Protection: '1; mode=block' in Rails by default - use XSS Auditor and block page if XSS attack is detected. Set it to '0;' if you want to switch XSS Auditor off(useful if response contents scripts from request parameters)

@piton4eg
Copy link
Contributor Author

@senny yep, fixed

senny added a commit that referenced this pull request Aug 21, 2015
@senny senny merged commit acb2b07 into rails:master Aug 21, 2015
@senny
Copy link
Member

senny commented Aug 21, 2015

@piton4eg thank you 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants