10X speed improvements for AS::Dependencies.loadable_constants_for_path #21411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -421,13 +421,13 @@ def loadable_constants_for_path(path, bases = autoload_paths) | |||
|
|
|||
| bases.each do |root| | |||
| expanded_root = File.expand_path(root) | |||
| next unless %r{\A#{Regexp.escape(expanded_root)}(/|\\)} =~ expanded_path | |||
There was a problem hiding this comment.
I assume the \\ was for Windows support. But then nesting[0] == ?/ was kinda breaking it. Not sure what to do here, but I can test for both.
When the autoload_paths start to grows, this methods is quite a hotspot
>> ActiveSupport::Dependencies.autoload_paths.size
=> 49
>> Benchmark.ips { |x| x.report('baseline') { ActiveSupport::Dependencies.loadable_constants_for_path(File.expand_path('app/models/shop')) }}
Calculating -------------------------------------
baseline 90.000 i/100ms
-------------------------------------------------
baseline 1.073k (±20.2%) i/s - 4.950k
After the patch
Calculating -------------------------------------
patched 883.000 i/100ms
-------------------------------------------------
patched 11.050k (±19.7%) i/s - 50.331k
byroot
force-pushed
the
perf-improvement-in-dependencies-loadable-constants
branch
from
629f2da
to
2e0cd0f
Compare
|
After fixing the test failure it's slightly slower, still about 9 times faster than current implementation though: |
rafaelfranca
added a commit
that referenced
this pull request
Aug 28, 2015
…s-loadable-constants 10X speed improvements for AS::Dependencies.loadable_constants_for_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the autoload_paths start to grows, this methods is quite a hotspot
After the patch
cc @rafaelfranca