Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActiveRecord::Tasks::DatabaseTasks.migrations_paths explicit for db tasks #21529

Merged
merged 1 commit into from
Sep 9, 2015
Merged

Use ActiveRecord::Tasks::DatabaseTasks.migrations_paths explicit for db tasks #21529

merged 1 commit into from
Sep 9, 2015

Conversation

rngtng
Copy link

@rngtng rngtng commented Sep 7, 2015

This defines source of truth for migrations_paths for running db rake tasks clearly by passing ActiveRecord::Tasks::DatabaseTasks.migrations_paths explicit to Migrator and avoids setting Migrator.migrations_paths instead.

As its mainly a cosmetic change I couldn't think of any way write a test. Ideas?

Follow up on #21527 /cc @senny

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@senny senny assigned senny and unassigned rafaelfranca Sep 7, 2015
@senny senny merged commit 5b9ae1b into rails:master Sep 9, 2015
senny added a commit that referenced this pull request Sep 9, 2015
…se-task

Use `ActiveRecord::Tasks::DatabaseTasks.migrations_paths` explicit for db tasks
@senny
Copy link
Member

senny commented Sep 9, 2015

I kept the assignment of ActiveRecord::Migrator.migrations_paths for now (a29db73...dfb89c9). While not immediately obvious this has some side effects on code further down the stack. I'm working on a refactoring towards removing it entirely.

@rngtng thank you 💛

@rngtng rngtng deleted the move-migrations-paths-to-database-task branch October 7, 2015 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants