Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RHTML reference in Action Controller docs #21585

Merged
merged 1 commit into from
Sep 11, 2015

Conversation

lachlanjc
Copy link
Contributor

This PR fixes the text in the Action Controller docs, where it mentions that the static error pages don't use RHTML.

Original:

You can customize these files to add some extra information and layout, but remember that they are static; i.e. you can't use RHTML or layouts in them, just plain HTML.

Revised:

You can customize these files to add some extra information and style, but remember that they are static HTML; i.e. you can't use ERB, SCSS, CoffeeScript, or layouts for them.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eileencodes
Copy link
Member

Thanks for the PR @lachlanjc! Can you squash your commits into one commit? Here's some info on how to do that: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History 😄

@lachlanjc
Copy link
Contributor Author

@eileencodes Ok! I just removed them both and re-committed. How do my changes look?

eileencodes added a commit that referenced this pull request Sep 11, 2015
Remove RHTML reference in Action Controller docs
@eileencodes eileencodes merged commit bbf0d35 into rails:master Sep 11, 2015
@eileencodes
Copy link
Member

Thanks for the quick update!

@lachlanjc
Copy link
Contributor Author

And for the quick review! 💥🙌😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants