Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HSTS default expire in ActionDispatch::SSL docs. #21617

Merged
merged 1 commit into from
Sep 14, 2015

Conversation

lunks
Copy link
Contributor

@lunks lunks commented Sep 14, 2015

I've changed wording a bit to reflect that 180 days is recommended according to #21520 CHANGELOG update, but still make it clear that the minimum is 18 weeks.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@lunks lunks changed the title Fix HSTS default expire in ActionDispatch::SSL. Fix HSTS default expire in ActionDispatch::SSL docs. Sep 14, 2015
claudiob added a commit that referenced this pull request Sep 14, 2015
Fix HSTS default expire in ActionDispatch::SSL docs.
@claudiob claudiob merged commit 174a57e into rails:master Sep 14, 2015
@claudiob
Copy link
Member

Thanks!

Next time you open a pull request that only affects documentation, make sure to include [ci skip] in your commit message 😁

@lunks
Copy link
Contributor Author

lunks commented Sep 14, 2015

whoops

@lunks lunks deleted the patch-1 branch November 4, 2015 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants